Feature/salesforce correctness 2 #4506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 9, 2025 19:20
…ure/salesforce-correctness-2 # Conflicts: # backend/onyx/connectors/salesforce/connector.py # backend/onyx/connectors/salesforce/salesforce_calls.py # backend/onyx/connectors/salesforce/sqlite_functions.py
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the Salesforce connector by improving time filtering logic and object type handling for better data synchronization.
- Changed
fetch_all_csvs_in_parallelinsalesforce_calls.pyto use a dictionary parameter that explicitly maps object types to filtering preferences - Added new
_get_all_typesstatic method inconnector.pyto better separate concerns when collecting Salesforce object types - Implemented smarter time filtering that only applies filters to object types already present in the database
- Removed commented-out code in
sqlite_functions.pyfor better code cleanliness - Improved CSV information logging with detailed statistics about downloaded files
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
…ure/salesforce-correctness-2
evan-onyx
approved these changes
Apr 18, 2025
| because this occurs after we check for existing csvs which covers this case""" | ||
| all_types_to_filter: dict[str, bool] = {} | ||
| for sf_type in all_types: | ||
| if sf_db.has_at_least_one_object_of_type(sf_type): |
There was a problem hiding this comment.
slight preference for
all_types_to_filter[sf_type] = sf_db.has_at_least_one_object_of_type(sf_type)
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
* refactor salesforce sqlite db access * more refactoring * refactor again * refactor again * rename object * add finalizer to ensure db connection is always closed * avoid unnecessarily nesting connections and commit regularly when possible * remove db usage from csv download * dead code * hide deprecation warning in ddtrace * remove unused param --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* refactor salesforce sqlite db access * more refactoring * refactor again * refactor again * rename object * add finalizer to ensure db connection is always closed * avoid unnecessarily nesting connections and commit regularly when possible * remove db usage from csv download * dead code * hide deprecation warning in ddtrace * remove unused param --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs https://linear.app/danswer/issue/DAN-1791/salesforce-correctness
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.