Feature/celery beat watchdog #4534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements a watchdog mechanism for monitoring and auto-restarting the Celery beat scheduler when it becomes unresponsive, using Redis-based heartbeat tracking.
- Critical bug:
monitor-celery-beattask inbeat_schedule.pyincorrectly usesMONITOR_PROCESS_MEMORYinstead of a dedicated monitoring task type - Unreachable log message in
supervisord_watchdog.pydue to infinite loop in main function - Missing error handling for
subprocess.callinsupervisord_watchdog.pywhen restarting processes - Typo in log message ("succeded") in
supervisord_watchdog.py - Celery version upgrade from beta (5.5.0b4) to stable (5.5.1) improves reliability
8 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
| f"elapsed_threshold={MAX_AGE_SECONDS}" | ||
| ) | ||
|
|
||
| subprocess.call(["supervisorctl", "-c", conf, "restart", program]) |
There was a problem hiding this comment.
logic: subprocess.call return value should be checked for errors
Suggested change
| subprocess.call(["supervisorctl", "-c", conf, "restart", program]) | |
| result = subprocess.call(["supervisorctl", "-c", conf, "restart", program]) | |
| if result != 0: | |
| logger.error(f"Failed to restart {program} (exit code {result})") |
Weves
approved these changes
Apr 15, 2025
added 2 commits
April 15, 2025 14:22
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
* upgrade celery to release version * make the watchdog script more reusable * use constant * code review * catch interrupt --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* upgrade celery to release version * make the watchdog script more reusable * use constant * code review * catch interrupt --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1820/watchdog-on-celery-beat-in-supervisord
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.