fix: Remove alert upon submission of LLM Provider #4537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR removes a development debugging alert that was exposing internal form validation state when submitting the LLM Provider configuration form.
- Removed
alert(JSON.stringify(formikProps.errors))from/web/src/app/admin/configuration/llm/LLMProviderUpdateForm.tsxwhich was unnecessarily exposing form validation details - Form maintains proper error handling through Formik validation schema and UI components
- Change improves user experience by removing technical debugging output that provided no user value
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
evan-onyx
approved these changes
Apr 16, 2025
Weves
approved these changes
Apr 16, 2025
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an LLM Provider is enabled, an
alertis fired which prints a dict. This was probably left in during development. This PR removes that.Addresses: https://linear.app/danswer/issue/DAN-1824/remove-alert-upon-enablement-editing-of-an-llm-provider.
How Has This Been Tested?
This simply removes a print-out. Manually tested. No further testing required.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.