small improvement to checking for image attachments #4543
Merged
+24
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds an early media type check for image attachments in the Confluence connector to prevent unnecessary downloads of images when they are not allowed.
- Added early
media_type.startswith("image/")check inconnector.pyto skip image downloads whenallow_imagesis False - Removed redundant metadata access in
validate_attachment_filetypefunction inutils.py - Added TODO comment highlighting potential refactoring opportunity around file type validation consistency
- Improved logging messages to better explain why attachments are being skipped
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
* small improvement to checking for image attachments * better comments * check centralized list of types instead of hardcoding them in the connector --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* small improvement to checking for image attachments * better comments * check centralized list of types instead of hardcoding them in the connector --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1816/confluence-image-attachments-being-downloaded-unexpectedly
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.