Pull in more fields for Jira #4547
Merged
+110
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced the Jira connector to extract and store additional metadata fields from Jira issues, including issue types, assignees, reporters, and timestamps.
- Added field name constants (
_FIELD_*) inconnector.pyto improve maintainability and consistency - Updated
process_jira_issue()to extract additional metadata fields (priority, status, labels, due dates) - Fixed display name extraction in
best_effort_basic_expert_info()to match Jira's API format - Added comprehensive test coverage for Story and Epic issue types with full metadata validation
- Improved error handling for field extraction with best-effort approach to prevent failures
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| page_url = build_jira_url(jira_client, issue.key) | ||
|
|
||
| metadata_dict: dict[str, str | list[str]] = {} |
There was a problem hiding this comment.
style: metadata_dict type annotation allows both str and list[str], but some fields like created and duedate could be datetime objects
Comment on lines
+26
to
+27
| if hasattr(obj, "displayName"): | ||
| display_name = obj.displayName |
There was a problem hiding this comment.
logic: Inconsistent fallback - line 29 uses get('displayName') but line 27 uses direct attribute access which could raise AttributeError
rkuo-danswer
approved these changes
Apr 17, 2025
2 tasks
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
* Pull in more fields for Jira * Fix tests * Fix * more fix * Fix * Fix S3 test * fix
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Pull in more fields for Jira * Fix tests * Fix * more fix * Fix * Fix S3 test * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1834/pull-in-more-fields-for-jira
How Has This Been Tested?
Connector tests + tested with Jira server locally.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.