Add o3 + o4 mini #4555
Merged
Add o3 + o4 mini #4555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
evan-onyx
approved these changes
Apr 18, 2025
| "gpt-4": "GPT 4", | ||
| "gpt-4o": "GPT 4o", | ||
| "o4-mini": "o4 Mini", | ||
| o3: "o3", |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the litellm package and adds new OpenAI models (o3 and o4-mini) across backend and frontend configurations.
- Updated litellm from 1.66.1 to 1.66.3 in
/backend/requirements/default.txtand/backend/requirements/model_server.txt - Added new models 'o4-mini' and 'o3' to
OPEN_AI_MODEL_NAMESin/backend/onyx/llm/llm_provider_options.py - Testing details are missing in PR description despite critical litellm dependency changes
- Consider requiring backport decision to be explicitly documented in PR template
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
43
to
48
| OPEN_AI_MODEL_NAMES = [ | ||
| "o4-mini", | ||
| "o3-mini", | ||
| "o1-mini", | ||
| "o3", | ||
| "o1", |
There was a problem hiding this comment.
style: Model ordering is inconsistent - 'o4-mini' is placed before 'o3-mini' and 'o3', breaking the apparent pattern of grouping related models together
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1839/add-models-o3-o4-mini
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.