address getting attachments forever #4562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the Confluence connector to address an issue with continuous attachment retrieval and improve error visibility.
- Added logging at document processing start to surface attachment retrieval issues faster
- Modified checkpoint logic to return after batch processing regardless of document errors
- Renamed
doc_counttoyield_countto accurately reflect tracking of both documents and errors - Added comprehensive test coverage in
/backend/tests/unit/onyx/connectors/confluence/test_confluence_checkpointing.pyto verify checkpoint behavior - Improved error handling for attachment processing in
_fetch_page_attachmentsmethod
The changes follow the repository's principles of failing loudly and providing clear error visibility while maintaining strict typing and clear logical boundaries.
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
Apr 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
* address getting attachments forever * fix unit tests
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* address getting attachments forever * fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses https://linear.app/danswer/issue/DAN-1848/confluence-churning-forever-without-checkpointing
Address Behavior we've seen where a connector appears to just continuously get attachments. We now return a checkpoint after the outer for loop has attempted to process a batch of documents, whether they had errors or not. We also log when we start processing documents. This is intended to help with some 403s on attachment retrieval we've been seeing by surfacing the issue faster.
How Has This Been Tested?
tests tbd
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.