Skip to content

Conversation

joachim-danswer
Copy link
Contributor

Description

Removal of 1st phase keyword search component

How Has This Been Tested?

Tested locally

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@joachim-danswer joachim-danswer requested a review from a team as a code owner April 23, 2025 03:19
Copy link

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 3:22am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Removed the first phase keyword search component from the search pipeline, simplifying the retrieval process but potentially impacting search performance.

  • Eliminated top_base_chunks_keyword_ranking_thread and associated logic in doc_index_retrieval, reducing parallel search operations from 3 to 2
  • Modified chunk combination logic to only use top_base_chunks_standard_ranking + top_keyword_chunks, removing keyword ranking results
  • Potential impact on search quality for keyword-heavy queries due to reduced keyword-specific ranking
  • Consider monitoring search performance metrics to ensure accuracy is maintained, especially for keyword-focused searches
  • Verify that the remaining standard and semantic search components adequately handle keyword-heavy queries

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Weves Weves merged commit d8b0500 into main Apr 23, 2025
10 of 11 checks passed
@Weves Weves deleted the change-base-search branch April 23, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants