Fix tool choice #4596
Merged
Fix tool choice #4596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
commented
Apr 24, 2025
|
|
||
| async function updateCurrentMessageFIFO( | ||
| stack: CurrentMessageFIFO, | ||
| params: any |
There was a problem hiding this comment.
remove the evil any !
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes an issue with tool selection logic in the chat functionality, focusing on preventing automatic search behavior for assistants with tools.
- Removes
promptIdparameter fromsendMessagefunction in/web/src/app/chat/lib.tsxto fix incorrect tool triggering - Introduces
SendMessageParamsinterface for better type safety in message handling - Modifies search behavior to only trigger when explicitly requested via
queryOverrideorforceSearchflags - Updates
ChatPage.tsxto properly handle tool selection without defaulting to search - Aligns with tool constants defined in
/web/src/app/chat/tools/constants.tsfor consistent tool identification
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
* Fix tool choice * fix
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Fix tool choice * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1875/fix-tool-choice
How Has This Been Tested?
Tested an assistant with a tool before (would always search). Now it doesn't.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.