fix migration and add test #4615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes a bug in the Jira connector migration's downgrade path and adds comprehensive integration tests to verify both upgrade and downgrade functionality.
- Fixed serialization issue in
backend/alembic/versions/da42808081e3_migrate_jira_connectors_to_new_format.pyby addingjson.dumps()for old_config - Added thorough integration test in
backend/tests/integration/tests/migrations/test_migrations.pycovering full, minimal, and partial Jira connector configurations - Test verifies correct handling of URL splitting into base_url/project_key and preservation of optional fields like comment_email_blacklist
- Includes verification of proper reconstruction during downgrade path
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
Apr 25, 2025
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Apr 26, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses https://linear.app/danswer/issue/DAN-1910/fix-jira-migration-with-tests
Test for #4614
Turns out the downgrade had a small bug
TODO: skip the integration test once confirmed to work on the cloud
How Has This Been Tested?
Ran the integration test locally
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.