Bugfix/chat images #4618
Merged
Bugfix/chat images #4618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds support for proper image handling in chat functionality, focusing on MIME type validation and content type storage.
- Added
content_typecolumn toUserFilemodel in/backend/onyx/db/models.pywith corresponding Alembic migration - Introduced centralized MIME type validation in
/backend/onyx/file_processing/file_validation.pywith clear lists of supported and excluded image types - Added
mime_type_to_chat_file_typeutility in/backend/onyx/server/query_and_chat/chat_utils.pyto properly map MIME types to ChatFileType enums - Modified file upload handling in
/backend/onyx/server/query_and_chat/chat_backend.pyto preserve original file content and transparency - Added
UploadIntentenum in/web/src/app/chat/ChatPage.tsxto differentiate between ChatInputBar and FilePickerModal uploads
18 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
backend/alembic/versions/5c448911b12f_add_content_type_to_userfile.py
Outdated
Show resolved
Hide resolved
Weves
approved these changes
Apr 27, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* keep chatfiletype as image instead of user_knowledge * improve continue message * fix to image handling * greptile code review --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1850/cannot-upload-images-or-screenshots-into-chat-and-get-answers
Fixes image chips and inline image in first message and LLM analysis.
Still outstanding: images after the first message don't appear inline unless chat is fully reloaded.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.