Skip to content

Conversation

Subash-Mohan
Copy link
Contributor

This pull request includes integration tests for Slack bot interactions and configurations

Slack Connector Enhancements:

  • Updated the get_channel_messages function in backend/onyx/connectors/slack/connector.py to handle cases where the is_member field is unavailable, assuming the bot is always a member for DM channels.

Test Refactoring:

  • Refactored imports in multiple test files (conftest.py, test_permission_sync.py, test_prune.py) to use the centralized SlackManager from tests.integration.common_utils.managers.slack instead of the previous location. [1] [2] [3]

New Test Fixtures and Helpers:

  • Added a comprehensive slack_test_context fixture in backend/tests/integration/tests/slack/conftest.py to set up a Slack test environment, including creating bots, users, channels, and configurations.
  • Introduced utility functions in backend/tests/integration/tests/slack/slack_test_helpers.py for sending and receiving messages, updating channel configurations, and validating UI elements like buttons.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Apr 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2025 6:41am

Copy link

This PR is stale because it has been open 75 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Jul 19, 2025
Copy link

This PR was closed because it has been stalled for 90 days with no activity.

@github-actions github-actions bot closed this Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants