Fix LLM API key

[Weves]

Description

Fixes a few things:

1. Model configurations were getting wiped on every update (set to empty list).
2. You could not edit an LLM provider easily. If you tried to re-submit, it would try and use the "masked key" and fail.
3. We ran the "test" call on every update, even if nothing had changed.

Fixes https://linear.app/danswer/issue/DAN-1912/fix-misc-model-configuration-stuff

How Has This Been Tested?

Tested locally. In the future, might want to add e2e tests for these.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

• This PR should be backported (make sure to check that the backport attempt succeeds)
• [Optional] Override Linear Check

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
internal-search	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 27, 2025 10:20pm

[greptile-apps]

PR Summary

This PR fixes critical issues with LLM provider configuration management, focusing on API key handling, model configuration persistence, and test call optimization.

• Added api_key_changed flag in TestLLMRequest to prevent masked API keys from being used incorrectly during updates
• Modified API key handling in /backend/onyx/server/manage/llm/api.py to only use existing provider's key when not explicitly changed
• Added isEqual check in forms to prevent unnecessary test API calls when no changes are made
• Fixed model configurations persistence by properly handling the configurations array and max_input_tokens values
• Improved type safety with proper Yup validation and consistent null handling for optional fields

_{4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile}

[raunakab]

I think there's one small Greptile change that I think is important. Other than that, seems good to me.

Seems as if some of the misc mistakes in here are due to weird default initialization values that I set.