add sendgrid as option #4639
Merged
add sendgrid as option #4639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds SendGrid as an alternative email delivery service alongside SMTP, addressing an email sending issue while maintaining backward compatibility.
- Added SendGrid integration in
/backend/onyx/auth/email_utils.pywithsend_email_with_sendgrid()function for handling both HTML and plain text emails - Introduced
SENDGRID_API_KEYconfiguration in/backend/onyx/configs/app_configs.pywhile preserving existing SMTP settings - Added new dependencies in
/backend/requirements/default.txt: sendgrid (6.11.0), python-http-client (3.3.7), starkbank-ecdsa (2.2.0) - Created skipped test in
/backend/tests/unit/onyx/auth/test_email.pyto validate email functionality - Fixed typo in
/backend/onyx/chat/process_message.pyfromresponse_sumarytoresponse_summary
5 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
Apr 30, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* add sendgrid as option * code review * mypy --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1929/emails-not-sending.
How Has This Been Tested?
Added by default skipped test that sent an email.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.