restore caching and fix up some prefixing #4649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ix/docker-cache-redux # Conflicts: # .github/workflows/docker-build-push-web-container-on-tag.yml
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR restores Docker layer caching functionality across multiple workflow files by implementing S3-based caching with proper platform-specific prefixes and deployment type separation.
- Added DEPLOYMENT environment variable (
cloud/standalone) in all workflow files to properly segment caches - Implemented platform-specific cache prefixing (e.g.,
backend-linux-amd64) to prevent cache conflicts between architectures - Removed/commented out
no-cache: truedirectives that were preventing caching from working - Added proper matrix build support for
linux/amd64andlinux/arm64in backend container workflow - Fixed artifact naming patterns to include run IDs and prevent collisions between parallel builds
6 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
.github/workflows/docker-build-push-cloud-web-container-on-tag.yml
Outdated
Show resolved
Hide resolved
.github/workflows/docker-build-push-backend-container-on-tag.yml
Outdated
Show resolved
Hide resolved
.github/workflows/docker-build-push-model-server-container-on-tag.yml
Outdated
Show resolved
Hide resolved
added 2 commits
May 1, 2025 16:58
added 2 commits
May 1, 2025 19:45
raunakab
reviewed
May 2, 2025
.github/workflows/docker-build-push-cloud-web-container-on-tag.yml
Outdated
Show resolved
Hide resolved
.github/workflows/docker-build-push-model-server-container-on-tag.yml
Outdated
Show resolved
Hide resolved
raunakab
reviewed
May 2, 2025
added 2 commits
May 2, 2025 17:34
raunakab
approved these changes
May 5, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 8, 2025
* restore caching and fix up some prefixing * try backend matrix build and fix artifact names * need id * add backslashes to be consistent * fix no-cache * leave docker tags to the meta action * need checkout in merge * add comment * move spammy logs to debug status * bunch of no-cache updates * prefix --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* restore caching and fix up some prefixing * try backend matrix build and fix artifact names * need id * add backslashes to be consistent * fix no-cache * leave docker tags to the meta action * need checkout in merge * add comment * move spammy logs to debug status * bunch of no-cache updates * prefix --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1935/fix-up-docker-image-caching-on-build.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.