Bugfix/slack timeout #4652
Merged
Bugfix/slack timeout #4652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses Slack timeout issues by improving error message handling and channel list truncation for large Slack workspaces.
- Modified
/backend/onyx/background/celery/tasks/indexing/tasks.pyto truncate long exception messages to 1024 chars while preserving tracebacks - Updated
/backend/onyx/connectors/slack/connector.pyto limit channel list in error messages to 50 entries - Removed channel accessibility validation in
filter_channelsto prevent timeouts in workspaces with 100k+ channels - Added
itertoolsimport for list slicing functionality - Improved error message formatting for better readability when channels are not found
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
evan-onyx
approved these changes
May 2, 2025
| raise e | ||
|
|
||
| # special bulletproofing ... truncate long exception messages | ||
| sanitized_e = type(e)(str(e)[:1024]) |
There was a problem hiding this comment.
Might be good to turn this into a utility for the future
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* don't log all channels * print number of channels * sanitize indexing exception messages * harden vespa index swap * use constants and fix list generation --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1937/slack-unexpected-timeout
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.