Skip to content

Bugfix/slack timeout #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2025
+52 −10
Merged

Bugfix/slack timeout #4652

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a353019
don't log all channels
May 2, 2025
1df9313
print number of channels
May 2, 2025
5b4ca8e
sanitize indexing exception messages
May 2, 2025
fc5279e
harden vespa index swap
May 2, 2025
ff46f4e
use constants and fix list generation
May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion backend/onyx/background/celery/tasks/indexing/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,11 @@ def connector_indexing_task(
f"cc_pair={cc_pair_id} "
f"search_settings={search_settings_id}"
)
raise e

# special bulletproofing ... truncate long exception messages
sanitized_e = type(e)(str(e)[:1024])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to turn this into a utility for the future

sanitized_e.__traceback__ = e.__traceback__
raise sanitized_e

finally:
if lock.owned():
Expand Down
4 changes: 3 additions & 1 deletion backend/onyx/connectors/slack/connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import contextvars
import copy
import itertools
import re
from collections.abc import Callable
from collections.abc import Generator
Expand Down Expand Up @@ -292,7 +293,8 @@ def filter_channels(
if channel not in all_channel_names:
raise ValueError(
f"Channel '{channel}' not found in workspace. "
f"Available channels: {all_channel_names}"
f"Available channels (max 50 of {len(all_channel_names)} shown): "
f"{[itertools.islice(all_channel_names, 50)]}"
)

return [
Expand Down
Loading