possible mangling fix #4666
Merged
possible mangling fix #4666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a utility function to handle PyGithub's PaginatedList attribute access, specifically addressing an AttributeError related to the nextUrl property.
- Added
get_nextUrlfunction in/backend/onyx/connectors/github/connector.pyto handle both__nextUrlandnextUrlattribute variations - Modified existing code to use the new function instead of direct attribute access, improving resilience against PyGithub version differences
- Addresses a production issue where attribute access was failing due to Python name mangling
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
May 6, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 8, 2025
* possible mangling fix * fixed nextUrl setting * global bad
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* possible mangling fix * fixed nextUrl setting * global bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1940/attributeerror-paginatedlist-object-has-no-attribute-nexturl
(hopefully)
Fix for attribute not found error likely due to python name mangling.
How Has This Been Tested?
Automated tests because we have not yet reproduced this issue locally
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.