fix drive slowness #4668
Merged
fix drive slowness #4668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR optimizes the Google Drive connector's performance by reducing API call overhead and improving thread management to prevent rate limiting and hangs during document indexing.
- Reduced BATCHES_PER_CHECKPOINT from 10 to 1 in
/backend/onyx/connectors/google_drive/connector.pyto minimize redundant API calls - Added timeout and RefreshError handling to prevent connector hangs
- Optimized thread management by matching thread count to active user emails instead of fixed 50 threads
- Added per-user drive ID tracking to prevent duplicate processing
- Improved logging for better debugging and monitoring of API interactions
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
evan-onyx
force-pushed
the
perf/drive-checkpoint-speedup
branch
from
d8c10ca to
6827dc3
Compare
Weves
approved these changes
May 7, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 8, 2025
* fix slowness * no more silent failing for users * nits * no silly info transfer
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 9, 2025
* fix slowness * no more silent failing for users * nits * no silly info transfer
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* fix slowness * no more silent failing for users * nits * no silly info transfer
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* fix slowness * no more silent failing for users * nits * no silly info transfer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1945/make-drive-fast-again
We were seeing a lot of slowness with the drive connector, with occasional hangs that completely interrupted indexing. We believe this was due to many duplicate API calls, in some cases leading to some silent rate limiting from the google apis. We were running 50 generator threads in parallel to get 16 documents, returning a checkpoint, then entering with that checkpoint and starting 50 more generators... etc. Now we tie the number of threads to the number of user emails we process per checkpoint, and finish those users before returning a checkpoint. It remains to be seen whether this will work well across the board, but it will certainly greatly improve API call efficiency (and therefore speed).
How Has This Been Tested?
Tested manually
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.