fix github cursor pagination infinite loop #4673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses an infinite loop issue in GitHub's cursor-based pagination implementation by improving cursor URL state management and checkpoint handling.
- Fixed premature checkpoint returns by properly tracking cursor URL state transitions in
/backend/onyx/connectors/github/connector.py - Reduced
CURSOR_LOG_FREQUENCYfrom 100 to 50 for better progress monitoring - Added proper type casting for paginated list slicing to prevent type-related errors
- Improved error handling for missing repository cache in checkpoints
- Added comprehensive test coverage in
/backend/tests/unit/onyx/connectors/github/test_github_checkpointing.pyto validate pagination behavior
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
May 9, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 19, 2025
* fix infinite loop * unit test for infinite loop issue * mypy version * more logging * unbound locals
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* fix infinite loop * unit test for infinite loop issue * mypy version * more logging * unbound locals
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* fix infinite loop * unit test for infinite loop issue * mypy version * more logging * unbound locals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1950/github-cursor-pagination-infinite-loop-fix
Fix an issue where the cursor-based pagination for github resulted in an infinite loop due to returning a checkpoint too early
How Has This Been Tested?
tested manually, automated test of no infinite loop tbd
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.