Feature/helm separate workers #4679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2025 12:37
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR separates the monolithic Celery background worker into specialized worker deployments in the Helm charts, enabling better resource allocation and task management.
- Added 7 distinct Celery worker deployments in
/deployment/helm/charts/onyx/templates/for specialized tasks: indexing, heavy processing, light tasks, monitoring, primary tasks, user files indexing, and beat scheduling - Introduced
celery_sharedconfiguration invalues.yamlfor common image settings across workers - Each worker deployment uses dedicated queues (e.g.,
connector_indexing,monitoring,periodic_tasks) for task specialization - All workers currently run with privileged security context and root user access, which may need security review
- Resource limits and requests are undefined in
values.yaml, which should be configured for production deployments
9 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
backend/tests/integration/multitenant_tests/tenants/test_tenant_creation.py
Show resolved
Hide resolved
backend/tests/integration/multitenant_tests/tenants/test_tenant_creation.py
Show resolved
Hide resolved
backend/tests/integration/multitenant_tests/tenants/test_tenant_creation.py
Show resolved
Hide resolved
…ure/helm-separate-workers
…ure/helm-separate-workers # Conflicts: # backend/tests/integration/multitenant_tests/tenants/test_tenant_creation.py
Weves
approved these changes
May 13, 2025
| privileged: true | ||
| runAsUser: 0 | ||
| enableMiniChunk: "true" | ||
| resources: {} |
There was a problem hiding this comment.
is it best to leave all the resources as blank? Or do we have an idea of a reasonable resource limit/request we can put in based on our cloud?
There was a problem hiding this comment.
We could put something in. Was just defaulting to what was there.
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 19, 2025
* add test * try breaking out background workers * fix helm lint complaints * rename disabled files more * try different folder structure * fix beat selector * vespa setup should break on success * improved instructions for basic helm chart testing --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* add test * try breaking out background workers * fix helm lint complaints * rename disabled files more * try different folder structure * fix beat selector * vespa setup should break on success * improved instructions for basic helm chart testing --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* add test * try breaking out background workers * fix helm lint complaints * rename disabled files more * try different folder structure * fix beat selector * vespa setup should break on success * improved instructions for basic helm chart testing --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1956/update-helm-charts-to-separate-workers
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.