Fix/remove ee from mit #4682
Merged
Fix/remove ee from mit #4682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR moves several enterprise edition (EE) features and configurations from the MIT version to the EE version of Onyx, focusing on cleaning up code organization and dependencies.
Key changes:
- Relocated OAuth client configurations (Slack, Confluence, Google Drive) from EE to MIT version's app_configs.py
- Moved external group syncing and cloud task management to EE-specific directories
- Transferred query history export tasks from MIT to EE version
- Relocated standard answer models from EE to MIT version while maintaining functionality
- Implemented dynamic feature loading for EE-specific functionality using
fetch_ee_implementation_or_noop
The changes appear well-structured but there are a few concerns:
- Some files still contain EE imports that need to be addressed (e.g.,
ee.onyx.server.oauth.api_router) - Moving
get_all_query_history_export_tasksto EE while trying to remove EE references seems contradictory - The datetime usage in cleanup tasks doesn't account for timezone awareness
29 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile
Weves
force-pushed
the
fix/remove-ee-from-mit
branch
from
f574b54 to
d321d7f
Compare
rkuo-danswer
approved these changes
May 9, 2025
This was referenced May 12, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 19, 2025
* Remove some ee imports * more * Remove all ee imports * Fix * Autodiscover * fix * Fix typing * More celery task stuff * Fix import
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* Remove some ee imports * more * Remove all ee imports * Fix * Autodiscover * fix * Fix typing * More celery task stuff * Fix import
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Remove some ee imports * more * Remove all ee imports * Fix * Autodiscover * fix * Fix typing * More celery task stuff * Fix import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1955/remove-any-references-to-ee-code-from-the-mit-version-of-onyx
How Has This Been Tested?
Tested:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.