ensure we don't tag 'latest' with cloud images #4688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies Docker image tagging logic across multiple workflow files to prevent cloud images from being incorrectly tagged as 'latest'.
- Added
LATEST_TAGenvironment variable indocker-build-push-backend-container-on-tag.ymlthat requires both 'latest' in ref name AND absence of 'cloud' tag - Removed 'latest' tag functionality entirely from
docker-build-push-cloud-web-container-on-tag.yml - Fixed inconsistency in
docker-build-push-web-container-on-tag.ymlwhere LATEST_TAG only checks for 'latest' but not 'cloud' - Missing testing details in PR description need to be added before merging
- Recommend verifying changes across all workflow files to ensure consistent behavior
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
evan-onyx
approved these changes
May 12, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 19, 2025
* ensure we don't tag 'latest' with cloud images * add docker login to trivy * fix tag names * flavor latest false (no auto latest tags) * fix typo * only run the appropriate workflow for web --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app> Co-authored-by: Richard Kuo <rkuo@rkuo.com>
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* ensure we don't tag 'latest' with cloud images * add docker login to trivy * fix tag names * flavor latest false (no auto latest tags) * fix typo * only run the appropriate workflow for web --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app> Co-authored-by: Richard Kuo <rkuo@rkuo.com>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* ensure we don't tag 'latest' with cloud images * add docker login to trivy * fix tag names * flavor latest false (no auto latest tags) * fix typo * only run the appropriate workflow for web --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app> Co-authored-by: Richard Kuo <rkuo@rkuo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1961/cloud-images-are-being-tagged-as-latest
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.