Fix window_start #4689
Merged
Fix window_start #4689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
commented
May 11, 2025
| sanitized_e.__traceback__ = e.__traceback__ | ||
| raise sanitized_e | ||
| try: | ||
| sanitized_e = type(e)(str(e)[:1024]) |
There was a problem hiding this comment.
this previously raised an exception for exception types that needed more args
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes polling connector indexing by modifying how the start time window is determined, ensuring more accurate document polling through proper tracking of poll range timestamps.
- Added
poll_range_startandpoll_range_endfields in/backend/onyx/server/documents/models.pyto properly track polling windows - Modified
get_last_successful_attempt_poll_range_endin/backend/onyx/db/connector_credential_pair.pyto use actual poll end times instead of start times - Added comprehensive integration test in
/backend/tests/integration/tests/indexing/test_polling.pyto validate polling window behavior - Updated indexing logic in
/backend/onyx/background/indexing/run_indexing.pyto reuse polling windows for failed/canceled attempts - Enhanced error handling in
/backend/onyx/background/celery/tasks/indexing/tasks.pyfor exception sanitization failures
5 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
evan-onyx
approved these changes
May 11, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 19, 2025
* Fix window_start * Add comment
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* Fix window_start * Add comment
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Fix window_start * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1964/fix-poll-range-start
How Has This Been Tested?
Integration test.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.