Fix initial checkpoint save #4697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed checkpointing logic to ensure proper state persistence and recovery in indexing operations.
- Added initial checkpoint save in
run_indexing.pyimmediately after checkpoint creation/retrieval to prevent state loss on early failures - Removed redundant checkpoint save operation in
get_latest_valid_checkpointsince the checkpoint already exists in storage - Changes are well-tested through extensive unit and integration tests covering various checkpoint scenarios
- Fixes issue with checkpoint recovery when indexing fails before first document batch
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
evan-onyx
approved these changes
May 13, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 19, 2025
* Fix initial checkpoint save * Improve comment * Another small fix
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* Fix initial checkpoint save * Improve comment * Another small fix
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Fix initial checkpoint save * Improve comment * Another small fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1969/another-small-checkpointing-logic-fix
How Has This Been Tested?
Tested locally
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.