Use LiteLLM DB for determining model tool capability #4698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emerzon is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the model tool capability detection by leveraging LiteLLM's database instead of hardcoded lists, enabling support for newer AI models to use native tools.
- Replaced hardcoded
OPEN_AI_TOOL_CALLING_MODELSwith dynamic lookup inbackend/onyx/tools/utils.pyusingsupports_function_callingattribute - Updated LiteLLM from 1.66.3 to 1.69.0 in both requirements files to support the new functionality
- Implementation in
explicit_tool_calling_supported()now usesget_model_map()and_find_model_obj()for more flexible model support
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 19, 2025
* Bump LiteLLM * Use LiteLLM DB for determining model tool capability instead of using hardcoded list * Make function defaults explicit
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
* Bump LiteLLM * Use LiteLLM DB for determining model tool capability instead of using hardcoded list * Make function defaults explicit
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* Bump LiteLLM * Use LiteLLM DB for determining model tool capability instead of using hardcoded list * Make function defaults explicit
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Bump LiteLLM * Use LiteLLM DB for determining model tool capability instead of using hardcoded list * Make function defaults explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use LiteLLM DB for determining model tool capability instead of using a hardcoded list.
This enables newer models (Ie.
gpt-4.1,gemini-2.5) to use native tools.How Has This Been Tested?
Checked new models now can execute tools.