Skip to content

Conversation

Subash-Mohan
Copy link
Contributor

Description

Adjusted the CSS of slack config form for dark mode.

How Has This Been Tested?

By looking into the UI

Before Changes

Screenshot 2025-05-14 at 8 14 58 PM

After Changes

Screenshot 2025-05-14 at 8 08 56 PM

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Subash-Mohan Subash-Mohan requested a review from a team as a code owner May 14, 2025 14:51
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 2:51pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR implements dark mode UI fixes for the Slack configuration form, focusing on improved text contrast and component visibility.

  • Added labelClassName prop to CheckField component enabling custom label styling
  • Simplified radio button border styling in radio-group.tsx by removing redundant border classes
  • Added overflow-visible to General Configuration accordion to prevent content cutoff
  • Fixed text contrast for "Disable Default Configuration" checkbox by setting text-neutral-900 label color

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Subash-Mohan Subash-Mohan added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 9d41820 May 15, 2025
9 of 11 checks passed
@Subash-Mohan Subash-Mohan deleted the bugfix/slack-config-form-ui-fix branch May 15, 2025 06:45
ferdinandl007 pushed a commit to ferdinandl007/onyx that referenced this pull request May 19, 2025
Co-authored-by: Subash <subash@onyx.app>
aronszanto pushed a commit to aronszanto/onyx that referenced this pull request May 27, 2025
Co-authored-by: Subash <subash@onyx.app>
ZhipengHe pushed a commit to ZhipengHe/onyx that referenced this pull request Jun 6, 2025
Co-authored-by: Subash <subash@onyx.app>
AnkitTukatek pushed a commit to TukaTek/onyx that referenced this pull request Sep 23, 2025
Co-authored-by: Subash <subash@onyx.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants