v1 answer refactor #4721
Merged
v1 answer refactor #4721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the search pipeline and answer class to improve code organization and query handling. The changes primarily involve:
- Replaced
search_request.querywithprompt_builder.raw_user_queryacross multiple files for more direct query access - Moved from
search_request.personato directpersonaaccess in GraphInputs for better configuration granularity - Renamed
main_graph_buildertoagent_search_graph_builderand removed test_mode parameter - Simplified reranking settings access by moving from
search_request.rerank_settingsto directrerank_settingsfield - Improved error handling and validation for search tools and persona configurations
31 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
backend/onyx/agents/agent_search/dc_search_analysis/nodes/a4_consolidate_object_research.py
Outdated
Show resolved
Hide resolved
backend/onyx/agents/agent_search/dc_search_analysis/nodes/a2_research_object_source.py
Outdated
Show resolved
Hide resolved
backend/onyx/agents/agent_search/dc_search_analysis/nodes/a3_structure_research_by_object.py
Outdated
Show resolved
Hide resolved
backend/onyx/agents/agent_search/dc_search_analysis/nodes/a3_structure_research_by_object.py
Outdated
Show resolved
Hide resolved
backend/onyx/agents/agent_search/dc_search_analysis/nodes/a5_consolidate_research.py
Outdated
Show resolved
Hide resolved
backend/onyx/agents/agent_search/dc_search_analysis/nodes/a5_consolidate_research.py
Outdated
Show resolved
Hide resolved
backend/onyx/agents/agent_search/orchestration/nodes/choose_tool.py
Outdated
Show resolved
Hide resolved
Weves
approved these changes
May 20, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
* v1 answer refactor * fix tests * good catch, tests * more cleanup
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
* v1 answer refactor * fix tests * good catch, tests * more cleanup
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* v1 answer refactor * fix tests * good catch, tests * more cleanup
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* v1 answer refactor * fix tests * good catch, tests * more cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses https://linear.app/danswer/issue/DAN-1980/answer-and-searchpipeline-refactor
Refactor the answer class and search pipeline. Still a WIP.
How Has This Been Tested?
n/a
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.