Skip to content

Conversation

Orbital-Web
Copy link
Contributor

Description

Made it clearer that the button is disabled
image

How Has This Been Tested?

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Orbital-Web Orbital-Web requested review from Weves and raunakab May 16, 2025 20:20
@Orbital-Web Orbital-Web requested a review from a team as a code owner May 16, 2025 20:20
Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 8:23pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the visual feedback of the Continue button's disabled state in the connector navigation interface by adjusting its text color.

  • Modified NavigationRow.tsx to add disabled:text-neutral-400 class to the Continue button, making the disabled state more visually distinct
  • Maintains proper accessibility standards by using native button disabled states

💡 (4/5) You can add custom instructions or style guidelines for the bot here!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raunakab
Copy link
Contributor

@Orbital-Web Salesforce connector tests are failing (definitely unrelated), so feel free to force-merge!

@Orbital-Web Orbital-Web merged commit 0262002 into main May 16, 2025
10 of 11 checks passed
@Orbital-Web Orbital-Web deleted the fix-connector-continue branch May 16, 2025 22:43
ferdinandl007 pushed a commit to ferdinandl007/onyx that referenced this pull request May 19, 2025
aronszanto pushed a commit to aronszanto/onyx that referenced this pull request May 27, 2025
ZhipengHe pushed a commit to ZhipengHe/onyx that referenced this pull request Jun 6, 2025
AnkitTukatek pushed a commit to TukaTek/onyx that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants