anthropic fix #4733
Merged
anthropic fix #4733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
approved these changes
May 19, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified explicit_tool_calling_supported to disable tool calling for Anthropic models due to UI limitations and sequential tool calling constraints.
- Added comprehensive test coverage in
backend/tests/unit/onyx/tools/test_utils.pywith parameterized scenarios for Anthropic and non-Anthropic models - Modified
backend/onyx/tools/utils.pyto check against both provider name andlitellm.anthropic_modelslist - Added clear documentation explaining why Anthropic models need to be treated as non-tool-calling (UI limitations and error patterns)
- Implemented fail-safe checks to prevent tool calling when model is in
litellm.anthropic_modelslist, even if provider name differs
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
* anthropic fix * naming
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
* anthropic fix * naming
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* anthropic fix * naming
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* anthropic fix * naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://linear.app/danswer/issue/DAN-1990/fix-anthropic-tool-calling
Revert behavior from anthropic models to not use their tool calling support. Anthropic models generate text before and after tool calls, and also throw an error if they are provided tool call messages from an earlier conversation without corresponding tools. Because we don't support sequential tool calling and it makes our UI ugly, we treat anthropic as non-tool-calling.
How Has This Been Tested?
tested in UI and added a unit test
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.