don't fail on fake files #4735
Merged
don't fail on fake files #4735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added error handling for invalid Excel (.xlsx) and PowerPoint (.pptx) files, particularly recovery files, to prevent connector failures while maintaining proper error logging.
- Added
BadZipFileexception handling in/backend/onyx/file_processing/extract_file_text.pyfor bothpptx_to_textandxlsx_to_textfunctions - Implemented special debug-level logging for Excel recovery files (starting with '~') in
/backend/onyx/file_processing/extract_file_text.py - Added
file_nameparameter propagation throughextract_text_and_imagesfor more informative error messages - Modified
/backend/onyx/connectors/google_drive/doc_conversion.pyto only return text sections when extraction succeeds
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+358
to
+361
| if file_name.startswith("~"): | ||
| logger.debug(error_str + " (this is expected for files with ~)") | ||
| else: | ||
| logger.warning(error_str) |
There was a problem hiding this comment.
style: Consider using a constant for the '~' prefix to make the code more maintainable and document its significance (recovery file indicator)
Weves
approved these changes
May 19, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
* don't fail on fake files * solve at the source * oops * oops2
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
* don't fail on fake files * solve at the source * oops * oops2
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* don't fail on fake files * solve at the source * oops * oops2
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* don't fail on fake files * solve at the source * oops * oops2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://linear.app/danswer/issue/DAN-1991/drive-pptx-and-xlsx-invalid-zipfile
There are cases where .xlsx and .pptx files are invalid because they are actually recovery files. We don't need the connector to fail in these cases. So, we add limited error catching that lets us skip these files.
How Has This Been Tested?
n/a, should be strictly an improvement as it's just error handling
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.