make sure the permission client uses the proper retry handler #4737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes an issue with Slack permission clients not sharing retry handlers correctly by modifying the client initialization process and Redis-based rate limit handling.
- Critical bug in
backend/ee/onyx/external_permissions/slack/doc_sync.py: The properly configured WebClient with retry handler is immediately overwritten with a basic WebClient, negating the intended fix - Added static method
make_slack_web_clientinbackend/onyx/connectors/slack/connector.pyto ensure consistent retry handler configuration across all clients - Improved Redis client initialization with proper tenant ID validation for rate limit tracking
- Moved delay lock and key generation to static methods for better encapsulation and reusability
- Recommend removing the redundant WebClient initialization in
doc_sync.pythat overwrites the properly configured client
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
May 20, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
…ot-app#4737) * make sure the permission client uses the proper retry handler * fix client --------- Co-authored-by: Richard Kuo <rkuo@rkuo.com>
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
…ot-app#4737) * make sure the permission client uses the proper retry handler * fix client --------- Co-authored-by: Richard Kuo <rkuo@rkuo.com>
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
…ot-app#4737) * make sure the permission client uses the proper retry handler * fix client --------- Co-authored-by: Richard Kuo <rkuo@rkuo.com>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
…ot-app#4737) * make sure the permission client uses the proper retry handler * fix client --------- Co-authored-by: Richard Kuo <rkuo@rkuo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1993/floqast-slack-permissions-not-sharing-retry-handler
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.