fix slack rate limit retry handler for groups #4742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances Slack integration by improving rate limit handling and credential management, particularly focusing on group synchronization and document permissions.
- Added Redis-based rate limiting in
backend/ee/onyx/external_permissions/slack/group_sync.pyusingSlackConnector.make_slack_web_client - Implemented
OnyxDBCredentialsProviderfor secure credential management in both sync files - Fixed potential edge case in
_get_slack_document_accesswherechannel_idmight not exist inchannel_permissions - Missing error handling for Slack API calls in
_fetch_channel_permissionsthat could fail due to rate limits - Inconsistent fix for 'license' typo, appears in two places but only fixed in one
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
May 20, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1995/selfdatabase-isnt-a-real-member-var
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.