Fix ext_perm_user sign-up for non multi-tenant #4743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes external permission user sign-up in non-multi-tenant deployments by modifying user session handling in backend/onyx/auth/users.py. The changes ensure proper tenant context management by:
- Gating session user lookup behind
MULTI_TENANTcheck inoauth_callbackmethod - Only attempting to get user from session if
MULTI_TENANTis True increatemethod - Ensuring user_db overwriting only occurs in multi-tenant mode
- Maintaining consistent user session handling based on deployment mode
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
rkuo-danswer
approved these changes
May 20, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
* OAuth w/ external user fix * Apply to basic auth as well
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
* OAuth w/ external user fix * Apply to basic auth as well
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* OAuth w/ external user fix * Apply to basic auth as well
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* OAuth w/ external user fix * Apply to basic auth as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
^
How Has This Been Tested?
Tested w/ customer
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.