fix: Add back Teams' replies processing #4744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR reintroduces Teams message replies processing, ensuring that replies are properly concatenated with their parent messages into single documents.
- Modified
_collect_document_for_channel_idinbackend/onyx/connectors/teams/connector.pyto fetch and include message replies in thread documents - Updated test expectations in
test_teams_connector.pyto verify concatenated message-reply combinations (e.g., "This is the first message...This is a reply!This is a second reply") - Renamed
_filter_messageto_should_process_messagefor better function naming clarity - Added proper timestamp validation to ensure messages and replies are within the specified time range
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
evan-onyx
reviewed
May 20, 2025
raunakab
force-pushed
the
fix/teams-replies
branch
from
66ab34c to
70f00cb
Compare
Weves
reviewed
May 20, 2025
rkuo-danswer
approved these changes
May 20, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
* Add replies to document construction and edit tests * Update tests * Add replies processing to teams * Fix test * Add try-except block around potential failure * Update entity-id during ConnectorFailure raise
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
* Add replies to document construction and edit tests * Update tests * Add replies processing to teams * Fix test * Add try-except block around potential failure * Update entity-id during ConnectorFailure raise
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* Add replies to document construction and edit tests * Update tests * Add replies processing to teams * Fix test * Add try-except block around potential failure * Update entity-id during ConnectorFailure raise
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Add replies to document construction and edit tests * Update tests * Add replies processing to teams * Fix test * Add try-except block around potential failure * Update entity-id during ConnectorFailure raise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous PR left out the processing of replies to a message. This PR adds it back.
Addresses: https://linear.app/danswer/issue/DAN-1997/teams-replies-not-being-parsed-and-processed-in-document.
How Has This Been Tested?
Tests were written in the previous PR. For this one, since replies are included, they have been updated to include the replies in the expected output.