improve impersonation logging slightly #4758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced error handling and logging in the impersonation endpoint to improve debugging capabilities and error clarity.
- Changed HTTP status code from 404 to 422 in
/backend/ee/onyx/server/tenants/admin_api.pyfor user not found scenarios - Added detailed error messages including both
emailandtenant_idcontext in impersonation failures - Implemented try-catch block around tenant_id lookup with warning level logging for better error tracking
- Added explicit warning logs for both missing tenant mapping and user not found cases
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
54
to
55
| if tenant_id is None: | ||
| raise exceptions.UserNotExists() |
There was a problem hiding this comment.
style: Consider logging a warning here when tenant_id is None to help distinguish between exception cases and missing tenant cases
Suggested change
| if tenant_id is None: | |
| raise exceptions.UserNotExists() | |
| if tenant_id is None: | |
| logger.warning(f"No tenant found for email {email}") | |
| raise exceptions.UserNotExists() |
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
current logging did not make the issue with an error here immediately obvious.
Fixes https://linear.app/danswer/issue/DAN-2004/improve-impersonation-logging.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.