add probes #4762
Merged
add probes #4762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added Kubernetes health probes (startup, readiness, liveness) across all Celery worker deployments to improve container lifecycle management and monitoring.
- Configured shared probe settings in
values.yamlwith specific timeouts: startup (2m), readiness (2m15s), and liveness (5m) - Added Python-based health check script execution in
/deployment/helm/charts/onyx/templates/celery-worker-*.yamlfiles - Each worker type (light, heavy, indexing, etc.) uses unique temporary files for probe status tracking
- Startup probe checks for
/app/onyx/main.pyexistence while readiness/liveness probes execute custom health checks - Potential concern: Probe script paths and temp file permissions need runtime verification
8 file(s) reviewed, 12 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
29
to
30
| * k -n onyx get pvc | ||
| * k -n onyx delete pvc vespa-storage-da-vespa-0 |
There was a problem hiding this comment.
style: Consider using full kubectl command instead of shorthand 'k' in documentation for clarity
Suggested change
| * k -n onyx get pvc | |
| * k -n onyx delete pvc vespa-storage-da-vespa-0 | |
| * kubectl -n onyx get pvc | |
| * kubectl -n onyx delete pvc vespa-storage-da-vespa-0 |
Weves
approved these changes
May 23, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
* add probes * lint fixes --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
* add probes * lint fixes --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* add probes * lint fixes --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* add probes * lint fixes --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-2009/add-k8s-probes-to-helm
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.