print sanitized api key to help troubleshoot #4764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added API key sanitization in error messages to help with troubleshooting embedding errors while maintaining security.
- Modified
backend/model_server/encoders.pyto include sanitized API key (first 4 and last 4 chars visible) in embedding error messages - Ensures sensitive API key information is protected while providing enough context for debugging
- Consider adding a test case to verify the API key sanitization logic works as expected
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| self.timeout = timeout | ||
| self.http_client = httpx.AsyncClient(timeout=timeout) | ||
| self._closed = False | ||
| self.sanitized_api_key = api_key[:4] + "********" + api_key[-4:] |
There was a problem hiding this comment.
style: Consider moving API key sanitization to a separate utility function for reuse and consistent sanitization across the codebase
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-2010/print-sanitized-api-key-in-embedding-exceptions-to-help
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.