Update GitHub Connector metadata #4769
Merged
+125
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updates GitHub connector metadata handling by adding comprehensive PR and issue tracking fields with proper timezone management in backend/onyx/connectors/github/connector.py.
- Added critical PR metadata fields (assignee, timestamps, merger info) with UTC timezone standardization
- Added issue tracking metadata (assignee, timestamps, labels) for better issue context
- Implemented None-value filtering in metadata using dictionary comprehension
- Maintains backward compatibility while enhancing data completeness
- Tested functionality with real-world PR and issue scenarios
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Orbital-Web
commented
May 29, 2025
| assert { | ||
| item.semantic_identifier for item in cast(list[Document], outputs[1].items) | ||
| } == {"PR 3 Repo 2", "PR 4 Repo 2"} | ||
| } == {"3: PR 3 Repo 2", "4: PR 4 Repo 2"} |
There was a problem hiding this comment.
This change is here because we add the pr/issue number to the semantic id (seems a little unnecessary here, but normally the title of the issue/pr wouldn't include the number).
This will be important for kg because we want to be able to search for the entity "4: Fixed ABC", when the user asks for PR 4.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
* feat: updated github metadata * feat: nullity check * feat: more metadata * feat: userinfo * test: connector test + more metadata * feat: num files changed * feat str * feat: list of str
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* feat: updated github metadata * feat: nullity check * feat: more metadata * feat: userinfo * test: connector test + more metadata * feat: num files changed * feat str * feat: list of str
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* feat: updated github metadata * feat: nullity check * feat: more metadata * feat: userinfo * test: connector test + more metadata * feat: num files changed * feat str * feat: list of str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
^
Will be relevant even more once kg is merged. Lets us filter specific types of PRs and Issues
How Has This Been Tested?
ran on my own repo with prs and issues
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.