connector filter bug fix #4771
connector filter bug fix #4771
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updates connector status display and filtering logic in the indexing status table to fix inconsistencies between displayed and filtered statuses.
- Modified status column in
/web/src/app/admin/indexing/status/CCPairIndexingStatusTable.tsxto uselast_finished_statusfor determining SCHEDULED vs INITIAL_INDEXING states - Updated filter logic to use
last_statusinstead oflast_finished_statusfor more accurate status filtering - Consider adding validation to ensure
last_statusandlast_finished_statusare properly synchronized to prevent future inconsistencies
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| status.last_finished_status as any | ||
| ) | ||
| ) { | ||
| if (!filterOptions.lastStatus.includes(status.last_status as any)) { |
There was a problem hiding this comment.
logic: Filtering by last_status instead of last_finished_status could show incorrect states for completed operations. Consider using both fields or adding additional validation.
| status.last_finished_status as any | ||
| ) | ||
| ) { | ||
| if (!filterOptions.lastStatus.includes(status.last_status as any)) { |
There was a problem hiding this comment.
why do we need to do status.last_status as any? that feels wrong
There was a problem hiding this comment.
There is no specific reason for that, now i changed the type.
|
Thanks @evan-onyx |
* connector filter bug fix * refactor: use ValidStatuses type for last status filter --------- Co-authored-by: Subash <subash@onyx.app>
* connector filter bug fix * refactor: use ValidStatuses type for last status filter --------- Co-authored-by: Subash <subash@onyx.app>
This pull request has updated logic for Status column to display the scheduled badge and changes for connector filtering.
How Has This Been Tested?
Tested in UI
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.