Skip to content

connector filter bug fix #4771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

connector filter bug fix #4771

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
163e13e
connector filter bug fix
subash-onyx May 24, 2025
3054093
refactor: use ValidStatuses type for last status filter
subash-onyx May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions web/src/app/admin/indexing/status/CCPairIndexingStatusTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,13 @@ border border-border dark:border-neutral-700
</TableCell>
<TableCell>
<CCPairStatus
ccPairStatus={ccPairsIndexingStatus.cc_pair_status}
ccPairStatus={
ccPairsIndexingStatus.last_finished_status !== null
? ccPairsIndexingStatus.cc_pair_status
: ccPairsIndexingStatus.last_status == "not_started"
? ConnectorCredentialPairStatus.SCHEDULED
: ConnectorCredentialPairStatus.INITIAL_INDEXING
}
inRepeatedErrorState={ccPairsIndexingStatus.in_repeated_error_state}
lastIndexAttemptStatus={
ccPairsIndexingStatus.latest_index_attempt?.status
Expand Down Expand Up @@ -322,11 +328,7 @@ export function CCPairIndexingStatusTable({

// Filter by last status
if (filterOptions.lastStatus && filterOptions.lastStatus.length > 0) {
if (
!filterOptions.lastStatus.includes(
status.last_finished_status as any
)
) {
if (!filterOptions.lastStatus.includes(status.last_status as any)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Filtering by last_status instead of last_finished_status could show incorrect states for completed operations. Consider using both fields or adding additional validation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to do status.last_status as any? that feels wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no specific reason for that, now i changed the type.

return false;
}
}
Expand Down
Loading