refactor: stream_llm_answer #4772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactored LLM answer streaming functionality across multiple agent components by introducing a centralized stream_llm_answer utility function.
- New
backend/onyx/agents/agent_search/shared_graph_utils/llm.pyimplements shared streaming logic with consistent error handling and timing measurements - Removed duplicate streaming code from
a5_consolidate_research.py,generate_validate_refined_answer.py,generate_initial_answer.py, andgenerate_sub_answer.py - Added type safety with
Literaltype foragent_answer_typeparameter - Improved error handling by explicitly checking content type before streaming
- Maintained consistent timeout and token restriction behavior across all agent components
5 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
backend/onyx/agents/agent_search/dc_search_analysis/nodes/a5_consolidate_research.py
Outdated
Show resolved
Hide resolved
evan-onyx
approved these changes
May 26, 2025
ferdinandl007
pushed a commit
to ferdinandl007/onyx
that referenced
this pull request
May 27, 2025
* refactor: stream_llm_answer * fix: lambda * fix: mypy, docstring
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
May 27, 2025
* refactor: stream_llm_answer * fix: lambda * fix: mypy, docstring
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* refactor: stream_llm_answer * fix: lambda * fix: mypy, docstring
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* refactor: stream_llm_answer * fix: lambda * fix: mypy, docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed a lot of duplicate code on the way the llm answer is streamed
How Has This Been Tested?
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.