Bugfix/slack bot debugging #4782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 28, 2025 10:11
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the Slack bot's logging and debugging capabilities, focusing on improved error tracing and code clarity without modifying core functionality.
- Added explicit type annotations and renamed variables in
/backend/onyx/onyxbot/slack/listener.pyfor better code clarity (e.g.,all_tenants->all_active_tenants) - Enhanced error logging in
/backend/onyx/onyxbot/slack/utils.pywith detailed messages for reaction operations - Added
bot_nameto socket client in/backend/onyx/onyxbot/slack/listener.pyfor improved request tracing - Reduced log verbosity in
/backend/onyx/secondary_llm_flows/chunk_usefulness.pyby removing redundant debug statements - Improved code organization in reaction handling by separating add/remove operations into distinct blocks
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
raunakab
approved these changes
May 28, 2025
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* adding some logging * better var name --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* adding some logging * better var name --------- Co-authored-by: Richard Kuo (Onyx) <rkuo@onyx.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-2013/improve-slack-bot-logging
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.