fix: Remove "Refining Answer" popup #4783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR removes the 'Refining Answer' popup functionality to fix a UI issue where it incorrectly appeared for already answered queries.
- Removed entire
web/src/app/chat/Refinement.tsxfile containing the popup components and related UI elements - Removed refinement-related props (
isImprovement,toggleDocDisplay,selectedDocuments) fromAgenticMessageandAIMessagecomponents - Hardcoded
isViewingInitialAnswerto true inAgenticMessage.tsxto prevent popup reappearance - Simplified state management by removing refinement-specific variables and imports across components
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| }, [hasThinkingTokens]); | ||
|
|
||
| const [isViewingInitialAnswer, setIsViewingInitialAnswer] = useState(true); | ||
| const isViewingInitialAnswer = true; |
There was a problem hiding this comment.
logic: hardcoding isViewingInitialAnswer to true removes the ability to view alternative answers - verify this is intended
Orbital-Web
approved these changes
May 28, 2025
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* Clean up logic * Remove dead code * Remove "Refining Answer" prompt
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Clean up logic * Remove dead code * Remove "Refining Answer" prompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "Refining Answer" would always pop up for previous already answered queries. This PR removes that code path altogether.
Addresses: https://linear.app/danswer/issue/DAN-1886/refining-answer-disappears-then-comes-back-before-finally-disappearing.
How Has This Been Tested?
This is a pure UI change; no tests were written.