Fixed indexing when no sites are specified #4822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wenxi-onyx
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed SharePoint connector's site listing functionality to properly discover and index all available sites when no specific sites are provided in the configuration.
- Modified
_fetch_sitesmethod inbackend/onyx/connectors/sharepoint/connector.pyto correctly iterate throughsites.current_pageinstead of using a singleresource_url - Improved site discovery by using each site's
web_urlfor building site descriptors, enabling comprehensive organization-wide indexing - Added support for automatic site discovery when no sites are explicitly specified in the connector configuration
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
231
to
241
| sites = self.graph_client.sites.get_all().execute_query() | ||
| site_descriptors = [ | ||
| SiteDescriptor( | ||
| url=sites.resource_url, | ||
| drive_name=None, | ||
| folder_path=None, | ||
| site_descriptors = [] | ||
| for site in sites.current_page: | ||
| site_descriptors.append( | ||
| SiteDescriptor( | ||
| url=site.web_url, | ||
| drive_name=None, | ||
| folder_path=None, | ||
| ) | ||
| ) | ||
| ] | ||
|
|
There was a problem hiding this comment.
logic: Consider handling pagination here - current_page suggests there might be more pages of sites that aren't being fetched
Suggested change
| sites = self.graph_client.sites.get_all().execute_query() | |
| site_descriptors = [ | |
| SiteDescriptor( | |
| url=sites.resource_url, | |
| drive_name=None, | |
| folder_path=None, | |
| site_descriptors = [] | |
| for site in sites.current_page: | |
| site_descriptors.append( | |
| SiteDescriptor( | |
| url=site.web_url, | |
| drive_name=None, | |
| folder_path=None, | |
| ) | |
| ) | |
| ] | |
| sites = self.graph_client.sites.get_all().execute_query() | |
| site_descriptors = [] | |
| while True: | |
| for site in sites.current_page: | |
| site_descriptors.append( | |
| SiteDescriptor( | |
| url=site.web_url, | |
| drive_name=None, | |
| folder_path=None, | |
| ) | |
| ) | |
| if not sites.has_next: | |
| break | |
| sites.get_next().execute_query() |
Weves
reviewed
Jun 4, 2025
There was a problem hiding this comment.
@wenxi-onyx can we add a test to the test_sharepoint_connector.py file that checks this case?
|
@Weves Added test - note that it only checks if any docs are retrieved. Does not assert "expected sites" because number of sites in our tenant may change at any time. |
Weves
approved these changes
Jun 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ZhipengHe
pushed a commit
to ZhipengHe/onyx
that referenced
this pull request
Jun 6, 2025
* Fixed indexing when no sites are specificed * Added test for Sharepoint all sites index * Accounted for paginated results. * Typing * Typing --------- Co-authored-by: Wenxi Onyx <wenxi-onyx@Wenxis-MacBook-Pro.local>
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Fixed indexing when no sites are specificed * Added test for Sharepoint all sites index * Accounted for paginated results. * Typing * Typing --------- Co-authored-by: Wenxi Onyx <wenxi-onyx@Wenxis-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sharepoint connector didn't correctly list sites in organization
Fixes https://linear.app/danswer/issue/DAN-2044/sharepoint-indexing-bug
How Has This Been Tested?
Created Sharepoint connector with no sites specified
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.