Small tweak to user invite flow #4825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improved form submission handling in the BulkAdd component by adding proper state management during form submission.
- Added
formikBag.setSubmitting(true/false)to properly disable submit button during form processing - Ensured submit state is always reset in
finallyblock to prevent button from staying disabled on errors - Added keyboard submit handling via Enter key while maintaining submission state management
- Improved email validation with regex pattern before submission
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
80
to
94
| handleSubmit: async (values: FormValues, formikBag) => { | ||
| const emails = values.emails.trim().split(WHITESPACE_SPLIT); | ||
| await addUsers("/api/manage/admin/users", { arg: emails }).then((res) => { | ||
| if (res.ok) { | ||
| formikBag.props.onSuccess(); | ||
| } else { | ||
| formikBag.props.onFailure(res); | ||
| } | ||
| }); | ||
| formikBag.setSubmitting(true); | ||
| await addUsers("/api/manage/admin/users", { arg: emails }) | ||
| .then((res) => { | ||
| if (res.ok) { | ||
| formikBag.props.onSuccess(); | ||
| } else { | ||
| formikBag.props.onFailure(res); | ||
| } | ||
| }) | ||
| .finally(() => { | ||
| formikBag.setSubmitting(false); | ||
| }); | ||
| }, |
There was a problem hiding this comment.
style: Using async/await with .then() is an anti-pattern. Either use pure async/await or pure promises.
Suggested change
| handleSubmit: async (values: FormValues, formikBag) => { | |
| const emails = values.emails.trim().split(WHITESPACE_SPLIT); | |
| await addUsers("/api/manage/admin/users", { arg: emails }).then((res) => { | |
| if (res.ok) { | |
| formikBag.props.onSuccess(); | |
| } else { | |
| formikBag.props.onFailure(res); | |
| } | |
| }); | |
| formikBag.setSubmitting(true); | |
| await addUsers("/api/manage/admin/users", { arg: emails }) | |
| .then((res) => { | |
| if (res.ok) { | |
| formikBag.props.onSuccess(); | |
| } else { | |
| formikBag.props.onFailure(res); | |
| } | |
| }) | |
| .finally(() => { | |
| formikBag.setSubmitting(false); | |
| }); | |
| }, | |
| handleSubmit: async (values: FormValues, formikBag) => { | |
| const emails = values.emails.trim().split(WHITESPACE_SPLIT); | |
| formikBag.setSubmitting(true); | |
| try { | |
| const res = await addUsers("/api/manage/admin/users", { arg: emails }); | |
| if (res.ok) { | |
| formikBag.props.onSuccess(); | |
| } else { | |
| formikBag.props.onFailure(res); | |
| } | |
| } finally { | |
| formikBag.setSubmitting(false); | |
| } | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.