Skip to content

Small tweak to user invite flow #4825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Small tweak to user invite flow #4825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions web/src/components/admin/users/BulkAdd.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,18 @@ const AddUserForm = withFormik<FormProps, FormValues>({
},
handleSubmit: async (values: FormValues, formikBag) => {
const emails = values.emails.trim().split(WHITESPACE_SPLIT);
await addUsers("/api/manage/admin/users", { arg: emails }).then((res) => {
if (res.ok) {
formikBag.props.onSuccess();
} else {
formikBag.props.onFailure(res);
}
});
formikBag.setSubmitting(true);
await addUsers("/api/manage/admin/users", { arg: emails })
.then((res) => {
if (res.ok) {
formikBag.props.onSuccess();
} else {
formikBag.props.onFailure(res);
}
})
.finally(() => {
formikBag.setSubmitting(false);
});
},
Comment on lines 80 to 94
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Using async/await with .then() is an anti-pattern. Either use pure async/await or pure promises.

Suggested change
handleSubmit: async (values: FormValues, formikBag) => {
const emails = values.emails.trim().split(WHITESPACE_SPLIT);
await addUsers("/api/manage/admin/users", { arg: emails }).then((res) => {
if (res.ok) {
formikBag.props.onSuccess();
} else {
formikBag.props.onFailure(res);
}
});
formikBag.setSubmitting(true);
await addUsers("/api/manage/admin/users", { arg: emails })
.then((res) => {
if (res.ok) {
formikBag.props.onSuccess();
} else {
formikBag.props.onFailure(res);
}
})
.finally(() => {
formikBag.setSubmitting(false);
});
},
handleSubmit: async (values: FormValues, formikBag) => {
const emails = values.emails.trim().split(WHITESPACE_SPLIT);
formikBag.setSubmitting(true);
try {
const res = await addUsers("/api/manage/admin/users", { arg: emails });
if (res.ok) {
formikBag.props.onSuccess();
} else {
formikBag.props.onFailure(res);
}
} finally {
formikBag.setSubmitting(false);
}
},

})(AddUserFormRenderer);

Expand Down
Loading