fix: Add rate-limiting to Teams API request #4854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added rate limiting to MS Teams connector API requests to prevent hitting service limits, specifically for message replies fetching.
- Implemented rate limiting decorator in
backend/onyx/connectors/teams/connector.pyto restrict Teams API calls to 50 requests per 60 seconds - Should consider adding scale testing infrastructure to properly validate rate limiting behavior
- Lack of testing capabilities for rate limiting implementation poses potential risk
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Weves
reviewed
Jun 9, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* Add rate-limiting to Teams API request * Add comment for rate-limiting * Implement rate-limiting for office365 library. * Remove hardcoded value * Fix nits on PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds rate-limiting to API requests made to MS Teams.
Addresses: https://linear.app/danswer/issue/DAN-2063/add-rate-limiting-to-ms-teams-connector-apis.
How Has This Been Tested?
The only way to test this would be through scale-testing, which we don't have just yet.