Kg vespa new schema #4864
Closed
Kg vespa new schema #4864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactors knowledge graph (KG) storage and filtering in Vespa, significantly changing how relationships and entities are handled to support more precise querying patterns.
- Changes KG storage format in
backend/onyx/document_index/vespa/app_config/schemas/danswer_chunk.sd.jinjafrom weightedset to array types with structured relationship storage - Implements fail-loud error handling in
backend/onyx/agents/agent_search/kb_search/nodes/a3_generate_simple_sql.pyby raising exceptions instead of silently continuing on SQL failures - Removes entity/relationship generalization (e.g., 'LINEAR::*') from
backend/onyx/document_index/vespa/kg_interactions.pyin favor of exact matching - Adds sophisticated KG filtering in
backend/onyx/document_index/vespa/shared_utils/vespa_request_builders.pywith support for wildcards and relationship-based queries
5 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
backend/onyx/agents/agent_search/kb_search/nodes/a3_generate_simple_sql.py
Outdated
Show resolved
Hide resolved
backend/onyx/agents/agent_search/kb_search/nodes/a3_generate_simple_sql.py
Outdated
Show resolved
Hide resolved
backend/onyx/agents/agent_search/kb_search/nodes/a3_generate_simple_sql.py
Outdated
Show resolved
Hide resolved
backend/onyx/document_index/vespa/shared_utils/vespa_request_builders.py
Show resolved
Hide resolved
backend/onyx/document_index/vespa/shared_utils/vespa_request_builders.py
Outdated
Show resolved
Hide resolved
backend/onyx/document_index/vespa/shared_utils/vespa_request_builders.py
Outdated
Show resolved
Hide resolved
Orbital-Web
force-pushed
the
kg-vespa-new-schema
branch
from
83a3fc3 to
dc0a7d4
Compare
Orbital-Web
force-pushed
the
kg-vespa-new-schema
branch
from
8cdc5b3 to
9954440
Compare
Orbital-Web
force-pushed
the
kg-vespa-new-schema
branch
from
9954440 to
4002130
Compare
|
Merging with the subtype pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IMPORTANT MAYBE?: Run kg_rs_vespa inside KG Dev Assistant if you have already extracted & clustered some kg stuff
Updated how kg relationships and entities are stored/filtered in vespa
How Has This Been Tested?
Locally, with these questions:
Filtered Search Entity
Filtered Search Relations
Made sure normal search works fine
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.