remove lru cache #4865
Merged
remove lru cache #4865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Removes lru_cache implementation from Google Drive connector to fix memory leak issues where cached objects were never being garbage collected.
- Removed
backend/onyx/utils/lazy.pywhich contained problematiclru_cacheimplementation causing memory leaks - Modified
backend/onyx/connectors/google_drive/doc_conversion.pyto directly initialize services instead of using lazy evaluation - Potential performance impact from removing caching, but necessary tradeoff for memory stability
- Consider monitoring service initialization performance impact
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Weves
approved these changes
Jun 10, 2025
AnkitTukatek
pushed a commit
to TukaTek/onyx
that referenced
this pull request
Sep 23, 2025
* remove lru cache * fix types issue * mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-2070/lru-cache-removal
It turns out lru_cache never(?) gets garbage collected. that's awkward.
How Has This Been Tested?
n/a
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.